Update CHANGELOG.md for Flutter 3.41.5#183792
Update CHANGELOG.md for Flutter 3.41.5#183792auto-submit[bot] merged 2 commits intoflutter-3.41-candidate.0from
Conversation
Added release notes for Flutter version 3.41.5, including issues and pull requests.
|
This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter. Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed. |
![gemini-code-assist[bot]](proxy.php?url=https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the CHANGELOG.md with release notes for Flutter 3.41.5. My review identified a minor typo in one of the new entries. Additionally, one of the entries describes an internal CI configuration change, which may not be relevant for end-users according to the repository's documentation guidelines. I've left comments with suggestions for both points.
| ## Flutter 3.41 Changes | ||
|
|
||
| ### [3.41.5](https://github.com/flutter/flutter/releases/tag/3.41.5) | ||
| - [flutter/182708](https://github.com/flutter/flutter/issues/182708) When using Impeller on any platform, bur artifacts in circles rendering at 45 degree angles. |
There was a problem hiding this comment.
There appears to be a typo in this release note. "bur" should likely be "blur".
| - [flutter/182708](https://github.com/flutter/flutter/issues/182708) When using Impeller on any platform, bur artifacts in circles rendering at 45 degree angles. | |
| - [flutter/182708](https://github.com/flutter/flutter/issues/182708) When using Impeller on any platform, blur artifacts in circles rendering at 45 degree angles. |
There was a problem hiding this comment.
Bur is the correct term here based on #182708!
There was a problem hiding this comment.
Oh, you're right! Carry on
CHANGELOG.md
Outdated
|
|
||
| ### [3.41.5](https://github.com/flutter/flutter/releases/tag/3.41.5) | ||
| - [flutter/182708](https://github.com/flutter/flutter/issues/182708) When using Impeller on any platform, bur artifacts in circles rendering at 45 degree angles. | ||
| - [flutter/183551](https://github.com/flutter/flutter/pull/183551) Configuration change for Github workflow commits. |
There was a problem hiding this comment.
This changelog entry seems to describe an internal configuration change for the repository's CI workflow. According to the repository style guide, documentation should be useful. This entry may not be relevant for Flutter developers. Please consider removing it, or rephrasing it to be more user-centric if it has any user-facing impact. The docs/releases/Hotfix-Documentation-Best-Practices.md file also provides more specific guidance for hotfix messages that emphasizes user-facing problem descriptions.
References
- Line 55 of the repository style guide states that 'Documentation should be useful'. The changelog entry about a CI configuration change may not be useful to Flutter developers. (link)
There was a problem hiding this comment.
@eyebrowsoffire was thinking about leaving this out -- lmk what you think
There was a problem hiding this comment.
Yes, I think we should omit this. It doesn't affect code that is consumed by the end user, so it doesn't need a changelog note.
Removed a pull request entry related to GitHub workflow commits from the changelog.
eyebrowsoffire
left a comment
eyebrowsoffire
left a comment
There was a problem hiding this comment.
LGTM, although Gemini you might want to fix that typo that Gemini is pointing out.
camsim99
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
|
auto label is removed for flutter/flutter/183792, Failed to merge flutter/flutter/183792 with Pull request flutter/flutter/183792 could not be merged: Required status check "ci.yaml validation" is expected.. |
camsim99
added
autosubmit
Add release notes for Flutter version 3.41.5 from #183792 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [AI contribution guidelines]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2 participants
Added release notes for Flutter version 3.41.5 that includes:
#183526
#183551
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.