Revert "Linux reuse sibling (#183653)"#183871
Conversation
This reverts commit ed5bda4.
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
github-actions
bot
added
engine
![gemini-code-assist[bot]](proxy.php?url=https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request reverts changes made to engine/src/flutter/shell/platform/linux/fl_compositor_opengl.cc. The changes remove the render_sibling member from the _FlCompositorOpenGL struct, revert the order of operations for framebuffer recreation upon resize, and handle the sibling framebuffer within the render function using a local variable rather than a class member. These changes effectively undo a previous commit to resolve a regression.
|
@robert-ancell I apologize for breaking that. I'll try to reproduce locally the issue and fix it. May I reach out to you for some help in reproducing the issue if I get stuck? |
|
@richardexfo no problem - I suggest you make a new PR set to draft with this change and we can discuss there if you are unable to reproduce. |
3 participants
This reverts commit ed5bda4.
When running the
examples/multiple_windowsand creating a regular window then closing it causes the content of the main window to stop being updated. The terminal shows: