Conversation
There was a problem hiding this comment.
Done. Added some comments here and below too about not letting WidgetsApp make a navigator.
There was a problem hiding this comment.
iirc, some of the docs in this file were subtly different than those in widgets/app.dart in various minor ways. Please verify that the ones you've removed are in fact the same byte-for-byte.
There was a problem hiding this comment.
Reverted some unintended merging of MaterialApp's doc into WidgetsApp. Mainly references to routes. Double checked that the delete docs from MaterialApp appear word for word in the template.
|
can we get away with not including the Navigator in CupertinoApp at all? |
|
In the current state, for consistency with MaterialApp, no :( Though I think if you extract a router out of the MaterialApp in a future refactor, it's worth removing it from here as well. |
There was a problem hiding this comment.
Semi tangential, I don't think this is true in the MaterialApp. We never actually create an actual Route and put a widget inside that says you did something wrong. We just print FlutterErrors.
I'm gonna remove this sentence.
This reverts commit 828a92a. Reverting in order to push segmented control golden files.
|
|
…merged in time
|
Waiting for the engine roll (which has a golden update queued up) before merging. |
4 participants
Part 1 of #18037