Fix Dart 2 issue in flutter doctor's VS Code detection#18998
Merged
DanTup merged 1 commit intoflutter:masterfrom Jul 3, 2018
DanTup:dart-2-issue
Merged
Fix Dart 2 issue in flutter doctor's VS Code detection#18998DanTup merged 1 commit intoflutter:masterfrom DanTup:dart-2-issue
flutter doctor's VS Code detection#18998DanTup merged 1 commit intoflutter:masterfrom
DanTup:dart-2-issue
Conversation
Fixes #18995.
devoncarew
approved these changes
Jul 2, 2018
Contributor
devoncarew
left a comment
devoncarew
left a comment
There was a problem hiding this comment.
Looks good (and mirrors what I have locally, when doing some quick preview dart 2 smoke testing).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #18995; a crash if you run doctor with
--preview-dart-2passed to the VM.I presume this is the correct fix. json.decode returns a
Map<String, dynamic>notString, Stringso this fixes this. However, the signature fordecodeactually just saysdynamicand this changes still feels slightly weird because I'm still assuming the value is aString.