Improve error message in microbenchmarks when flutter run lives too long#19200
Merged
DanTup merged 1 commit intoflutter:masterfrom Jul 10, 2018
DanTup:better-error-for-microbenchmarks-fail
Merged
Improve error message in microbenchmarks when flutter run lives too long#19200DanTup merged 1 commit intoflutter:masterfrom DanTup:better-error-for-microbenchmarks-fail
DanTup merged 1 commit intoflutter:masterfrom
DanTup:better-error-for-microbenchmarks-fail
Conversation
This should make it more obvious from the error what's gone wrong if we see a repeat of #19096 (previously the error was something like "Bad state: future already completed").
devoncarew
approved these changes
Jul 10, 2018
Contributor
|
nice! thanks |
Hixie
reviewed
Jul 10, 2018
| // https://github.com/flutter/flutter/issues/19096#issuecomment-402756549 | ||
| if (resultsHaveBeenParsed) { | ||
| throw 'Additional JSON was received after results has already been ' | ||
| 'processed. This suggests the `flutter run` process may have lived ' |
Contributor
There was a problem hiding this comment.
minor nit: please try to keep expressions vertically aligned (so in this case, making the leading apostrophes all be in the same vertical column); it makes reading the code much easier (because you can tell at a glance that it's one expression and how they nest).
Contributor
Author
There was a problem hiding this comment.
Makes sense - thanks! I updated here -> #19256
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should make it more obvious from the error what's gone wrong if we see a repeat of #19096 (previously the error was something like "Bad state: future already completed").
See #19096 (comment)