Revert "Roll engine to 4466d61a993fdbde2cb092b4da9bbef33d1962fe (#192…#19233
Merged
cbracken merged 1 commit intoflutter:masterfrom Jul 10, 2018
Merged
Revert "Roll engine to 4466d61a993fdbde2cb092b4da9bbef33d1962fe (#192…#19233cbracken merged 1 commit intoflutter:masterfrom
cbracken merged 1 commit intoflutter:masterfrom
Conversation
Causes microbenchmarks to start failing. This included the following engine PR, which appears to be the culprit: * Remove vmservice_io.main from entry points. (flutter/engine#5625) This reverts commit 3643790.
Member
Author
|
TBR: @aam |
liyuqian
approved these changes
Jul 10, 2018
Member
Author
|
Landing on red to fix microbenchmarks. flutter/engine#5625 appears to be the culprit for issue #19096/#19210. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…30)"
Causes microbenchmarks to start failing. This included the following
engine PR, which appears to be the culprit:
This reverts commit 3643790.