Removes trailing whitespace from source files.#19329
Removes trailing whitespace from source files.#19329gspencergoog merged 5 commits intoflutter:masterfrom
Conversation
gspencergoog
force-pushed
the
trailing_whitespace
branch
2 times, most recently
from
6558062 to
2dc2f99
Compare
dev/bots/test.dart
Outdated
There was a problem hiding this comment.
Shall we also include ".m" and ".mm"?
dev/bots/test.dart
Outdated
There was a problem hiding this comment.
Shall we only check files that are changed in the PR? That way, the check could be faster and we don't have to remove all the trailing spaces in this PR.
There was a problem hiding this comment.
Yeah, that's a good idea. It also means that we won't encounter false-positive issues in generated files.
dev/bots/test.dart
Outdated
There was a problem hiding this comment.
I like this. Copied to my PR: flutter/engine#5733
gspencergoog
force-pushed
the
trailing_whitespace
branch
from
12bd1ea to
e65789a
Compare
|
OK, PTAL. The code now only checks for whitespace on changed files. |
gspencergoog
force-pushed
the
trailing_whitespace
branch
from
e65789a to
6165345
Compare
|
The code looks good to me. However, some tests are failing... It seems that the branch master is not available on some test bots, and some unit tests are matching texts on those that we changed the white spaces. Maybe we can revert all those white spaces changes in this PR so it can pass the test, and then remove trailing spaces and refactor unit tests later? |
gspencergoog
changed the title
There was a problem hiding this comment.
Are these changes intentional?
There was a problem hiding this comment.
Yes. You can't tell from the diff, but there were raw formfeed characters in between the I and the J. I just changed these to make them more obvious and explicit. Same for the other lines in this file.
|
OK, I moved the presubmit check to #19412. I'll address the lack of a master branch there. |
gspencergoog
force-pushed
the
trailing_whitespace
branch
from
9c8180f to
516b85b
Compare
gspencergoog
force-pushed
the
trailing_whitespace
branch
from
516b85b to
d52a951
Compare
| No valid code signing certificates were found | ||
| You can connect to your Apple Developer account by signing in with your Apple ID | ||
| in Xcode and create an iOS Development Certificate as well as a Provisioning | ||
| in Xcode and create an iOS Development Certificate as well as a Provisioning\u0020 |
There was a problem hiding this comment.
Because this line has an embedded space in the test, but I didn't want to just remove it, because it appeared that it was just mocking something that the real iOS tools output.
So I converted it to an escape sequence so that the whitespace presubmit check I have in the other PR won't fail because there's a space here. I'd really prefer a linter rule for EOL whitespace, but it doesn't exist yet.
I'm happy to just fix the test and remove the whitespace if you think that won't be a problem. If I did that, I'd just remove the last part of the string in the test.
5 participants
There are only whitespace changes here, except for
packages/flutter/test/foundation/licenses_test.dart, where I replace some raw whitespace (line feed) with their unicode equivalents.I'm adding a presubmit check for this in #19412.