Add presubmit test for trailing whitespace.#19412
Merged
gspencergoog merged 2 commits intoflutter:masterfrom Jul 20, 2018
Merged
Add presubmit test for trailing whitespace.#19412gspencergoog merged 2 commits intoflutter:masterfrom
gspencergoog merged 2 commits intoflutter:masterfrom
Conversation
Contributor
Author
|
Filed an issue with Cirrus CI to find out how to get the right git hash to compare with: |
gspencergoog
force-pushed
the
whitespace_presubmit
branch
from
7ac8007 to
0e56667
Compare
Contributor
|
@gspencergoog : FYI, @jason-simmons is running into similar problems where master branch can't be found in his local machine. I think that he's going to use upstream/master for the diff. |
Contributor
Author
|
The way I have it here is the one recommended by the Cirrus CI guy, and seems to work. Are you sure upstream is defined? |
liyuqian
approved these changes
Jul 16, 2018
Contributor
liyuqian
left a comment
liyuqian
left a comment
There was a problem hiding this comment.
Oh, I didn't notice that cirruslabs/cirrus-ci-docs#17 is already resolved. Yes, the Cirrus CI recommended solution looks better. LGTM.
gspencergoog
force-pushed
the
whitespace_presubmit
branch
4 times, most recently
from
aa6f5c6 to
6c7895a
Compare
gspencergoog
force-pushed
the
whitespace_presubmit
branch
from
6c7895a to
9c1412b
Compare
liyuqian
added a commit
to liyuqian/engine
that referenced
this pull request
Jul 20, 2018
The new approach follows flutter/flutter#19412 which is suggested by Cirrus in cirruslabs/cirrus-ci-docs#17
liyuqian
added a commit
to flutter/engine
that referenced
this pull request
Jul 20, 2018
The new approach follows flutter/flutter#19412 which is suggested by Cirrus in cirruslabs/cirrus-ci-docs#17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've removed all trailing whitespace from the repo in #19329, this adds a presubmit check to keep it that way.