Feature pesto new recipes#19415
Merged
willlarche merged 10 commits intoflutter:masterfrom Aug 17, 2018
Merged
Conversation
Contributor
|
LGTM. Wait for LGTM from @HansMuller before merging. Please also post a before and an after screenshots. |
tianlunlee
force-pushed
the
feature-pesto-new-recipes
branch
from
9f84446 to
77f4d43
Compare
willlarche
approved these changes
Jul 21, 2018
tianlunlee
force-pushed
the
feature-pesto-new-recipes
branch
from
373ab27 to
dfd0c7e
Compare
willlarche
reviewed
Jul 25, 2018
Contributor
There was a problem hiding this comment.
Why do you need a time for this step?
Contributor
Author
There was a problem hiding this comment.
It's the only step without a duration, but it's not necessary
Contributor
There was a problem hiding this comment.
Ah. I guess take it out then.
Contributor
|
LGTM |
tianlunlee
force-pushed
the
feature-pesto-new-recipes
branch
2 times, most recently
from
44220e3 to
ead0603
Compare
tianlunlee
force-pushed
the
feature-pesto-new-recipes
branch
3 times, most recently
from
48728c3 to
77c9f19
Compare
This reverts commit 983b5fe38329070f075ec723d59bc9b62f1d73e7.
tianlunlee
force-pushed
the
feature-pesto-new-recipes
branch
from
68a952a to
f122a21
Compare
Contributor
|
Here's another LGTM for good measure: LGTM |
Hixie
added a commit
that referenced
this pull request
Aug 18, 2018
* Revert "Deprecated CupertinoDialog in favor of a new widget called CupertinoP… (#20649)" This reverts commit 3a4ae28. * Revert "Feature pesto new recipes (#19415)" This reverts commit e2f3b3d. * Revert "Use markdown table (#20721)" This reverts commit 82d43b9. * Revert "Documentation regarding tap gesture callbacks (#20647)" This reverts commit 3acc278. * Revert "Add branch to footer information in flutter docs (#20711)" This reverts commit 9118d3d. * Revert "Performance test cleanup (#20652)" This reverts commit 1993a67. * Revert "Track number of package dependencies in Flutter (#20722)" This reverts commit 03d6f18.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.