Roll engine to version b148e628ec86b3a9a0382e0bcfae73f0390a8232#20427
Roll engine to version b148e628ec86b3a9a0382e0bcfae73f0390a8232#20427mkustermann merged 10 commits intoflutter:masterfrom
Conversation
|
There seems to be issues with mockito package: |
|
Turns out Siva's roll in the engine wasn't further rolled into flutter/flutter yet. Doing this will require upgrading all 3rd party packages in pubspec files to be compatible with Dart 2, since this roll includes a new version number, namely I've tried to find all the necessary package upgrades and filed issues for:
So far. |
There was a problem hiding this comment.
Please don't do this. It's a breaking change for our users.
There was a problem hiding this comment.
Guess this issue has been resolved already by #20602
This includes: Roll Dart to version be6309690fd60284a87f3258a740c7c30efb1092 (flutter#5987)
…t to avoid defaulting to <2.0.0
…ter_tester will crash very deeply inside Dart VM
|
The SEGV crash in the After debugging this for a while it became clear that this is due to a missing platform file, which caused the VM to fall back to code paths which it should never fall back to in a Dart 2.0 world. The root cause was flutter/engine@a84b210 which renamed the platform file the |
|
Since the engine->flutter roll also brings in new skia changes, I've made flutter/goldens#11 to update the goldens. |
|
still LGTM |
|
The existing redness on the flutter dashboard needs to be investigated, e.g. I can see e.g. |
Reason for revert: The package:flutter_gallery_assets has removed some images which are required for the examples/flutter_gallery, so the gallery build is failing (only discovered after landing, since gallery doesn't seem to get built during github PR presubmit checks)
This is a re-land with downgraded `package:flutter_gallery_assets` version.
* Reland "Roll engine to version b148e62 (#20427)" This is a re-land with downgraded `package:flutter_gallery_assets` version. * Downgrade package:flutter_gallery_assets to 0.1.4 * Change engine.version to 81baff9 (which contains an additional fix) * Change engine.version to e3687f7 (since mac tarballs are corrupted on earlier commit)
This includes:
Roll Dart to version be6309690fd60284a87f3258a740c7c30efb1092 (#5987)