Reland Flutter tool support for dynamic code #20543#20646
Merged
sbaranov merged 2 commits intoflutter:masterfrom Aug 16, 2018
sbaranov:flutter-dynamic-flag
Merged
Reland Flutter tool support for dynamic code #20543#20646sbaranov merged 2 commits intoflutter:masterfrom sbaranov:flutter-dynamic-flag
sbaranov merged 2 commits intoflutter:masterfrom
sbaranov:flutter-dynamic-flag
Conversation
jonahwilliams
requested review from
cbracken
and removed request for
jonahwilliams
Contributor
|
Adding @cbracken since I know very little about the mac builds |
sbaranov
changed the title
cbracken
approved these changes
Aug 15, 2018
| throw new UsageException('Only one of --debug, --profile, or --release can be specified.', null); | ||
| final bool dynamicFlag = argParser.options.containsKey('dynamic') | ||
| ? argResults['dynamic'] | ||
| : false; |
Member
There was a problem hiding this comment.
Maybe just:
final bool dynamicFlag = argResults['dynamic'] ?? false;
since Map returns null when a key isn't present, and either way we'd never want dynamicFlag to be null.
Contributor
Author
There was a problem hiding this comment.
Unfortunately, this isn't a regular map. It overrides [] and will throw if flag doesn't exist. So this is the patterns that's used everywhere for argResults.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.