Deprecated CupertinoDialog in favor of a new widget called CupertinoP…#20649
Conversation
| /// and action sheet. | ||
| /// | ||
| /// A [CupertinoPopupSurface] can be configured to paint or not paint its white | ||
| /// foreground color. Typical usage should paint the foreground. The foreground |
There was a problem hiding this comment.
Clarify wording wrt 'foreground'. It's still the background from the perspective of its child. Specify that it's the thing between the blur and the child.
| /// actions. | ||
| /// * <https://developer.apple.com/ios/human-interface-guidelines/views/alerts/> | ||
| class CupertinoPopupSurface extends StatelessWidget { | ||
| /// Creates an iOS-style rectangular popup surface. |
| this.child, | ||
| }) : super(key: key); | ||
|
|
||
| /// Whether or not to paint a translucent white foreground on top of this |
There was a problem hiding this comment.
Describe what it's for (i.e. why not let this always be false)
There was a problem hiding this comment.
the purpose is described in the class description
| child: new BackdropFilter( | ||
| filter: new ImageFilter.blur(sigmaX: _kBlurAmount, sigmaY: _kBlurAmount), | ||
| child: new Container( | ||
| width: _kCupertinoDialogWidth, |
There was a problem hiding this comment.
This shouldn't be here right?
To test the general composability of this, move this to a different file and remove the word dialog from the various private consts that can now be moved.
There was a problem hiding this comment.
I moved the width decision up a level.
|
LGTM. This is probably the last time we will ever deprecate something, now that we are going into "stable" mode. |
|
@Hixie "Ever"? |
|
Hopefully! |
|
@Hixie how would that work? Every framework I've ever heard of has had many breaking changes across releases....let alone deprecations....how will Flutter be different? |
|
LGTM |
* Revert "Deprecated CupertinoDialog in favor of a new widget called CupertinoP… (#20649)" This reverts commit 3a4ae28. * Revert "Feature pesto new recipes (#19415)" This reverts commit e2f3b3d. * Revert "Use markdown table (#20721)" This reverts commit 82d43b9. * Revert "Documentation regarding tap gesture callbacks (#20647)" This reverts commit 3acc278. * Revert "Add branch to footer information in flutter docs (#20711)" This reverts commit 9118d3d. * Revert "Performance test cleanup (#20652)" This reverts commit 1993a67. * Revert "Track number of package dependencies in Flutter (#20722)" This reverts commit 03d6f18.
4 participants
Deprecated CupertinoDialog in favor of a new widget called CupertinoPopupSurface. (#20397)