Add localization for expand icon collapse/expand tap hint#20766
Add localization for expand icon collapse/expand tap hint#20766jonahwilliams merged 5 commits intoflutter:masterfrom
Conversation
HansMuller
left a comment
HansMuller
left a comment
There was a problem hiding this comment.
This generally looks fine; just want to sort out the icon theme test color change.
|
|
||
| final IconTheme iconTheme = tester.firstWidget(find.byType(IconTheme)); | ||
| expect(iconTheme.data.color, equals(Colors.black26)); | ||
| expect(iconTheme.data.color, equals(Colors.black)); |
There was a problem hiding this comment.
This change doesn't appear to be related to the PR or the issues the PR addresses. In fact black doesn't seem like a disabled color..
There was a problem hiding this comment.
I believe this just changed because I wrapped the app in a MaterialWidget
There was a problem hiding this comment.
The iconTheme issue appears to be related to: #3188
There was a problem hiding this comment.
According to the spec, the disabled color for icons should be black.withOpacity(0.38)
There was a problem hiding this comment.
Should I wait until this is resolved or just ignore it and let it be cleaned up by the fix?
There was a problem hiding this comment.
actually nvm, I need to make sure this is still disabled.
There was a problem hiding this comment.
Okay, the issue was that the finder was looking for the first theme. Changed to the last theme to get the disable theme. Otherwise we get the material apps default theme
|
|
||
| "expandedIconTapHint": "Collapse", | ||
| "@expandedIconTapHint": { | ||
| "description": "The verb infinitive which describes what happens when an expanded ExpandIcon is activated." |
There was a problem hiding this comment.
It might be more helpful to describe this translation as describing what happens an expanded ExpandIcon toggle button is pressed. Likewise for @collapsedIconTapHint.
There was a problem hiding this comment.
This one is tricky because it is used in a very specific way to override part of Talkback's hint text. For example:
Value: expand
Talkback: "double tap to expand"
Value: to expand
Talback: "double tap to to expand"
So it needs to be phrased very carefully ... and this also depends on how Talkback translates the phrase as well.
|
LGTM |
3 participants
Also fixes ExpansionPanelHeader to properly merge semantics.
Fixes #20739
Fixes #19909
Fixes #19910