Track number of package dependencies in Flutter#20831
Merged
Hixie merged 2 commits intoflutter:masterfrom Aug 21, 2018
Merged
Conversation
That way we don't need `flutter` on the PATH.
Contributor
Author
|
cc @tvolkert who reviewed the original |
Contributor
Author
|
@fkorotkov Sorry to bug you again! the |
Contributor
Author
|
(restarted broken shards) |
Contributor
|
@Hixie I think I know what happened to these unexpectedly terminated shards! Seems like an issues with killing of a process tree. Just deployed a fix. Please let me know if you'll see it ever again. |
Contributor
Author
|
@fkorotkov great! thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relands #20722, with the following change: "Use evalFlutter instead of startProcess. That way we don't need
flutteron the PATH."