Make helper and error text separate widgets, make error and counter live region#21752
Merged
jonahwilliams merged 3 commits intoflutter:masterfrom Sep 18, 2018
Merged
Make helper and error text separate widgets, make error and counter live region#21752jonahwilliams merged 3 commits intoflutter:masterfrom
jonahwilliams merged 3 commits intoflutter:masterfrom
Conversation
jonahwilliams
changed the title
yjbanov
approved these changes
Sep 18, 2018
Contributor
|
|
hereisderek
added a commit
to hereisderek/flutter
that referenced
this pull request
Sep 18, 2018
…dle-fix * commit '3c22d7b025642abd865160970d39f8c5ba7d3162': clarify how to display an image with a specific density (flutter#21152) Roll engine 9e315e6..2e8e96f (2 commits) (flutter#22005) Make helper and error text separate widgets, make error and counter live region (flutter#21752) Use Xcode legacy build system for iOS builds (flutter#21901) (flutter#21994) Run logcat through shell (flutter#21977) Add back screenshot extension that was temporarily disabled. (flutter#21828)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Separates the error/helper text and counter from the text field.
When the text field has focus, the counter acts as a live region and updates the remaining characters after typing:
When an error appears below a text field, this error will be read out once instead of using AccessibilityNodeInfo.setContentInvalid - this will read out "content invalid" after every character press instead of just once.
The error will potentially need to be made an assertive live region, pending specs