Update devicelab test for rename of materialize -> make-host-app-editable#22034
Merged
DanTup merged 1 commit intoflutter:masterfrom Sep 19, 2018
DanTup:fix-devicelab-test
Merged
Update devicelab test for rename of materialize -> make-host-app-editable#22034DanTup merged 1 commit intoflutter:masterfrom DanTup:fix-devicelab-test
DanTup merged 1 commit intoflutter:masterfrom
DanTup:fix-devicelab-test
Conversation
…able This fixes the devicelab failure after #22006 renamed this command.
tvolkert
approved these changes
Sep 19, 2018
Contributor
Author
|
I'll land once Cirrus finishes, though with a red Flutter build since this is the fix for the redness. |
Contributor
|
@DanTup thanks for taking care of this. Do we not run device lab tests in presubmit? |
Contributor
|
We don't run devicelab tests on presubmit (I've been bitten by this too). We don't have the resources in the devicelab to handle this for the large number of PR commits we get. You can run them locally, but that requires the correct host setup |
Contributor
Author
|
Yeah :( Though we do have the ability to write integration tests using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the devicelab failure after #22006 renamed this command.
(fyi @matthew-carroll)