Fixes to support add2app on iOS#22277
Merged
dnfield merged 4 commits intoflutter:masterfrom Sep 26, 2018
mravn:add2app_ios
Merged
Fixes to support add2app on iOS#22277dnfield merged 4 commits intoflutter:masterfrom mravn:add2app_ios
dnfield merged 4 commits intoflutter:masterfrom
mravn:add2app_ios
Conversation
Contributor
|
Does this break Xcode 9.4? Sorry about the misunderstanding on the other PR, thought it was good to go. |
Contributor
Author
|
@dnfield I don't think it does, but I'm not going to downgrade to 9.4 to test it tonight. Feel free, if you have 9.4 on a MacBook near you: Check out this PR in a branch, then Now you should be able to open No apologies needed about the other PR! My bad with all the checkmarks. Anyway, it went fine on the build bots, it seems :-) |
dnfield
reviewed
Sep 26, 2018
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

dev/integration_tests/ios_host_appto work in Xcode 10.0/cc @dnfield