Add support for text shadows.#22449
Conversation
|
See flutter/engine#6385 for Engine-side changes. |
GaryQian
changed the title
|
Tests will not pass until the engine is landed and rolled. |
|
This is still missing golden tests, but I wanted to do that in a separate patch to keep the merging of this one smooth. |
There was a problem hiding this comment.
ah, i would have expected this to be the class in dart:ui
GaryQian
force-pushed
the
shadows
branch
3 times, most recently
from
da9f0b2 to
e4a703a
Compare
|
Should this be called |
|
If you are referencing the class If you mean the 'shadows' property of TextStyle, since the "list of shadows" concept can be applied on multiple widgets, in order to keep it consistent and not have a Shadows prefix to each instance of shadows, I have called it just "shadows". I think this more unified API is a bit more predictable to work with. The fact that it is a Text shadow is signified by it being a property of TextStyle. |
GaryQian
force-pushed
the
shadows
branch
2 times, most recently
from
98024de to
18d770d
Compare
5 participants
This changes BoxShadow to inherit from Shadow (a new class without the spreadRadius)
TextStyle holds a
List<Shadow>.Fixes/Adds features for #3402