Create WidgetTester.ensureVisible(Finder)#22620
Merged
tvolkert merged 3 commits intoflutter:masterfrom Oct 18, 2018
devkabiir:fix_8185
Merged
Create WidgetTester.ensureVisible(Finder)#22620tvolkert merged 3 commits intoflutter:masterfrom devkabiir:fix_8185
tvolkert merged 3 commits intoflutter:masterfrom
devkabiir:fix_8185
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
Contributor
Author
|
I signed it |
|
CLAs look good, thanks! |
devkabiir
changed the title
tvolkert
approved these changes
Oct 18, 2018
Contributor
tvolkert
left a comment
tvolkert
left a comment
There was a problem hiding this comment.
Thanks for the contribution!
Contributor
There was a problem hiding this comment.
The distinction between the widget being made visible and the scrollable is a little confusing in the wording here. How about:
/// Given a widget `W` specified by [finder] and a [Scrollable] widget `S` in
/// its ancestry tree, this scrolls `S` so as to make `W` visible.
///
/// Shorthand for `Scrollable.ensureVisible(tester.element(finder))`
Contributor
Author
There was a problem hiding this comment.
Thanks, Yours is simpler. I'll update it.
This is just a shorthand for Scrollable.ensureVisible(tester.element(finder))
Signed-off-by: devkabiir <[email protected]>
tvolkert
reviewed
Oct 18, 2018
| /// its ancestry tree, this scrolls `S` so as to make `W` visible. | ||
| /// | ||
| /// Shorthand for `Scrollable.ensureVisible(tester.element(finder))` | ||
| Future<Null> ensureVisible(Finder finder) => Scrollable.ensureVisible(element(finder)); |
Contributor
There was a problem hiding this comment.
Analysis is failing because Future<void> is the modern replacement for Future<Null>
Contributor
Author
There was a problem hiding this comment.
Thanks, I was just trying to figure it out.
Future<void> is the modern replacment for Future<Null> Signed-off-by: devkabiir <[email protected]>
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 14, 2020
…urvives at least two frames (flutter#22620)" (flutter/engine#23044)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 14, 2020
…urvives at least two frames (flutter#22620)" (flutter/engine#23044)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 14, 2020
…urvives at least two frames (flutter#22620)" (flutter/engine#23044)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 15, 2020
…urvives at least two frames (flutter#22620)" (flutter/engine#23044)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is just a shorthand for
Scrollable.ensureVisible(tester.element(finder))closes #8185