Roll engine to 50c2e69da with goldens fix#23016
Merged
liyuqian merged 3 commits intoflutter:masterfrom Oct 12, 2018
Merged
Conversation
GaryQian
reviewed
Oct 12, 2018
Contributor
There was a problem hiding this comment.
There should be another place where this needs to be changed
Contributor
Author
There was a problem hiding this comment.
Good catch! Will update shortly.
liyuqian
added a commit
to flutter/goldens
that referenced
this pull request
Oct 12, 2018
GaryQian
approved these changes
Oct 12, 2018
gspencergoog
approved these changes
Oct 12, 2018
Member
|
cc @rmacnak-google who is finishing/starting the dart roll |
liyuqian
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goldens updated due to Skia AA changes. We previously also made a mistake by having a golden test run on MacOS.
git log 3ffa362..50c2e69 --no-merges --oneline
50c2e69 Roll src/third_party/skia 1b62fad4b188..b27a9cf2f4a8 (1 commits) (flutter/engine#6514)
8757bf2 Roll src/third_party/skia 05caa69a3f5a..1b62fad4b188 (2 commits) (flutter/engine#6513)
c2fd10a Roll src/third_party/skia 2a138544646d..05caa69a3f5a (1 commits) (flutter/engine#6512)