Override FLUTTER_BUILD_MODE for Add2App#23309
Closed
dnfield wants to merge 1 commit intoflutter:masterfrom
Closed
Conversation
cbracken
requested changes
Oct 19, 2018
Contributor
Author
|
@cbracken added a body to this - would you like some comments in the ruby file as well? |
cbracken
reviewed
Oct 19, 2018
| File.open(xcconfig_path, 'a+') do |file| | ||
| file.puts "#include \"#{File.join(framework_dir, 'Generated.xcconfig')}\"" | ||
| if config.name == 'Release' | ||
| file.puts "FLUTTER_BUILD_MODE=release" |
Member
There was a problem hiding this comment.
If I'm reading this right, this only affects pods, and not the main project, correct? Specifically, when building for simulator, we only support debug builds. (#17735)
Contributor
Author
|
I'm going to close this and open a separate PR with the approach we discussed this afternoon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flutter tooling creates a
Generated.xcconfigfile and sets aFLUTTER_BUILD_MODE=debug/release/profileas approrpiate. In an add to app scenario, we want this to be driven by the Xcode build mode. Current instructions tell users to create and update xcconfig files manually - this change will let Cocoapods take care of it for them.