Support null locale before locale initialization, Roll engine to cdd592f5be97e824#23375
Closed
GaryQian wants to merge 6 commits intoflutter:masterfrom
Closed
Support null locale before locale initialization, Roll engine to cdd592f5be97e824#23375GaryQian wants to merge 6 commits intoflutter:masterfrom
GaryQian wants to merge 6 commits intoflutter:masterfrom
Conversation
tvolkert
reviewed
Oct 22, 2018
|
|
||
| // Initial WidgetTester locale is new Locale('', '') | ||
| // Initial WidgetTester locale is null due to no platform intitializing it. | ||
| await tester.binding.setLocale('', ''); |
Contributor
There was a problem hiding this comment.
What happens if we don't do this? Can we adjust the expectations below? Namely, it seems like $locale shouldn't return "_", so we should probably adjust the toString() implementation of Locale
Contributor
Author
There was a problem hiding this comment.
Without this, the null handling (after the engine-side change) resolves the locale to the first supported locale, which is en_US. I'll go ahead and check for en_US and roll the engine with this test change.
Contributor
Author
There was a problem hiding this comment.
There should be no more Locale("", "") anymore, at least not produced by flutter.
tvolkert
approved these changes
Oct 22, 2018
yjbanov
approved these changes
Oct 22, 2018
Contributor
|
|
GaryQian
changed the title
tvolkert
approved these changes
Oct 22, 2018
Contributor
Author
|
Closing and reopening to attempt to force in latest changes (github is not updating this PR) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The engine will roll a change that makes uninitialized locales null very soon, but this still works without the change.
Engine Roll:
git log --oneline --no-merges 4c79e42..cdd592f
cdd592f Reland 'Pass null instead of 'none' locale' (#6632)
2cd8920 Roll src/third_party/skia b1a002e850e1..327955b1ba19 (12 commits) (#6631)
edfe024 13771 - iOS dictation bug (#6607)
cadf440 Roll src/third_party/skia b9998cdceec7..b1a002e850e1 (13 commits) (#6626)