Skip to content

Default locales test for flutter tester. Roll engine 162b2e98c03..7be0217d67969#23596

Merged
GaryQian merged 5 commits intoflutter:masterfrom
GaryQian:localeplatform
Oct 30, 2018
Merged

Default locales test for flutter tester. Roll engine 162b2e98c03..7be0217d67969#23596
GaryQian merged 5 commits intoflutter:masterfrom
GaryQian:localeplatform

Conversation

@GaryQian
Copy link
Contributor

@GaryQian GaryQian commented Oct 26, 2018 •
edited
Loading

Tests for the change described in flutter/engine#6673

Requires a manual engine roll.

@GaryQian GaryQian mentioned this pull request Oct 26, 2018
Closed
@GaryQian
Copy link
Contributor Author

GaryQian commented Oct 26, 2018

Moving the default locales into flutter_tester startup instead of the dart:ui code.

Hixie
Hixie reviewed Oct 27, 2018
View reviewed changes
packages/flutter_localizations/test/widgets_test.dart Outdated
Copy link
Contributor

@Hixie Hixie Oct 27, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this comment seems out of date

@GaryQian GaryQian mentioned this pull request Oct 29, 2018
Merged
@GaryQian GaryQian changed the title Add default locales test for platforms without locale passing Add default locales test for flutter tester default locales. Oct 29, 2018
@GaryQian GaryQian changed the title Add default locales test for flutter tester default locales. Default locales test for flutter tester. Oct 29, 2018
@GaryQian GaryQian mentioned this pull request Oct 29, 2018
Closed
@GaryQian GaryQian requested a review from chinmaygarde October 29, 2018 20:59
@GaryQian GaryQian mentioned this pull request Oct 29, 2018
Merged
@GaryQian
Copy link
Contributor Author

GaryQian commented Oct 30, 2018

Engine Roll:
git log --no-merges --oneline 162b2e9..7be0217
7be0217 Roll back _countryCode assert - breaking change (#6693)
91a019c Fix popSystemNavigator (#6691)
2b2fbf0 Add Locale.fromSubtags and support for scriptCode. (#6518)
58c8e30 Roll src/third_party/skia ab18c8e6cc20..d48b7a881b24 (5 commits) (#6690)
3b17cfb Flutter tester default locales (#6689)
96bbd2b Roll buildroot to 11a934e (#6687)
0e9defb Roll src/third_party/skia 68825776f4b4..ab18c8e6cc20 (11 commits) (#6688)
cc686d7 Don't populate the external view embedder in PaintContext. (#6686)
ab782fa Roll src/third_party/skia 1de48d8040aa..68825776f4b4 (1 commits) (#6685)
c4aa8d3 Roll src/third_party/skia 797197a772b8..1de48d8040aa (2 commits) (#6684)
7352251 Roll src/third_party/skia 79c96811863f..797197a772b8 (1 commits) (#6683)
3dac47e Roll src/third_party/skia 38e4fd0c5654..79c96811863f (1 commits) (#6682)
2f06a53 Roll src/third_party/skia b53f1f46982d..38e4fd0c5654 (1 commits) (#6681)
a1d7cad Fix inconsistent include syntax (#6680)
236661c Roll src/third_party/skia 3b79aa3a5ad0..b53f1f46982d (13 commits) (#6679)
c4f5061 Roll buildroot to pick up Mac toolchain updates. (#6678)
ba8f6aa Handle Windows headers defining ERROR to 0 in log levels. (#6677)
505d2a9 Roll buildroot to pick up updates to custom toolchains. (#6674)
6c2a0b3 Undefine ERROR in platform_view_layer.cc (#6675)
55e1299 Update FlutterPlugin.h docs, suppress warning for older API (#6672)
f797004 Attach and position embedded UIVIews (#6614)
df85722 Plumb the iOS PlatformViewsController into flow. (#6603)
2bfb893 iOS Embedding Refactor (#6447)

@GaryQian GaryQian changed the title Default locales test for flutter tester. Default locales test for flutter tester. Roll engine 162b2e98c03..7be0217d67969 Oct 30, 2018
@GaryQian GaryQian merged commit ec5719a into flutter:master Oct 30, 2018
Xavjer pushed a commit to Xavjer/flutter that referenced this pull request Nov 1, 2018
@GaryQian @Xavjer
Default locales test for flutter tester. Roll engine 162b2e9..7be0217 (…
7058513 
…flutter#23596)

162b2e9..7be0217
7be0217 Roll back _countryCode assert - breaking change (flutter#6693)
91a019c Fix popSystemNavigator (flutter#6691)
2b2fbf0 Add Locale.fromSubtags and support for scriptCode. (flutter#6518)
58c8e30 Roll src/third_party/skia ab18c8e6cc20..d48b7a881b24 (5 commits) (flutter#6690)
3b17cfb Flutter tester default locales (flutter#6689)
96bbd2b Roll buildroot to 11a934e (flutter#6687)
0e9defb Roll src/third_party/skia 68825776f4b4..ab18c8e6cc20 (11 commits) (flutter#6688)
cc686d7 Don't populate the external view embedder in PaintContext. (flutter#6686)
ab782fa Roll src/third_party/skia 1de48d8040aa..68825776f4b4 (1 commits) (flutter#6685)
c4aa8d3 Roll src/third_party/skia 797197a772b8..1de48d8040aa (2 commits) (flutter#6684)
7352251 Roll src/third_party/skia 79c96811863f..797197a772b8 (1 commits) (flutter#6683)
3dac47e Roll src/third_party/skia 38e4fd0c5654..79c96811863f (1 commits) (flutter#6682)
2f06a53 Roll src/third_party/skia b53f1f46982d..38e4fd0c5654 (1 commits) (flutter#6681)
a1d7cad Fix inconsistent include syntax (flutter#6680)
236661c Roll src/third_party/skia 3b79aa3a5ad0..b53f1f46982d (13 commits) (flutter#6679)
c4f5061 Roll buildroot to pick up Mac toolchain updates. (flutter#6678)
ba8f6aa Handle Windows headers defining ERROR to 0 in log levels. (flutter#6677)
505d2a9 Roll buildroot to pick up updates to custom toolchains. (flutter#6674)
6c2a0b3 Undefine ERROR in platform_view_layer.cc (flutter#6675)
55e1299 Update FlutterPlugin.h docs, suppress warning for older API (flutter#6672)
f797004 Attach and position embedded UIVIews (flutter#6614)
df85722 Plumb the iOS PlatformViewsController into flow. (flutter#6603)
2bfb893 iOS Embedding Refactor (flutter#6447)
@GaryQian GaryQian deleted the localeplatform branch November 29, 2018 01:21
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Hixie Hixie Hixie left review comments

@jason-simmons jason-simmons jason-simmons approved these changes

@chinmaygarde chinmaygarde Awaiting requested review from chinmaygarde

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@GaryQian @Hixie @jason-simmons @googlebot