Make the material DropdownButton's icon configurable.#23834
Make the material DropdownButton's icon configurable.#23834mfiels wants to merge 1 commit intoflutter:masterfrom
Conversation
|
@HansMuller could you review this? I know we would like to adhere to Material specs as much as possible and avoid API bloat. I don't recall Material allowing icon to be configurable. |
There was a problem hiding this comment.
This looks like a reasonable DropdownButton enhancement and I think making the icon configurable jibes with Material's emphasis on customization.
It would be more flexible if the icon's type was Widget and the IconTheme widget was used to configure the icon's size/color.
If icon is allowed to be null (also seems reasonable), the implementation needs to DTRT.
A test will be needed.
zoechi
added
framework
HansMuller
left a comment
HansMuller
left a comment
There was a problem hiding this comment.
Just a reminder: waiting for changes per the review
|
I'm going to close this PR since there hasn't been any activity for a while. |
5 participants
cc: @mehmetf