fix variable check in xcode_backend.sh#24368
Merged
dnfield merged 4 commits intoflutter:masterfrom Nov 15, 2018
Merged
Conversation
gspencergoog
requested changes
Nov 15, 2018
| # Sign the binaries we moved. | ||
| local identity="${EXPANDED_CODE_SIGN_IDENTITY_NAME:-$CODE_SIGN_IDENTITY}" | ||
| if (${identity} != ""); then | ||
| if [[ ! -z "$identity" ]]; then |
goderbauer
approved these changes
Nov 15, 2018
Member
goderbauer
left a comment
goderbauer
left a comment
There was a problem hiding this comment.
LGTM
Any chance we can write a tests that would have caught this?
gspencergoog
approved these changes
Nov 15, 2018
Contributor
Author
|
@goderbauer - I have some tests for this script, but it's hard to catch some of these that are more deeply nested without a full on integration test. I ended up reproducing this while working on an integration test that would catch it in the future. |
cbracken
approved these changes
Nov 15, 2018
Member
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #24343
The current test in there is wrong.
This also removes some trailing whitespace because my editor is now configured to do that automatically.