switching from hours to minutes when selecting or dragging hour#24677
switching from hours to minutes when selecting or dragging hour#24677sdolski wants to merge 1 commit intoflutter:masterfrom
Conversation
zoechi
added
framework
|
@estevez-dev Any timetable for merging this into the master branch? |
|
Thank you for this contribution and please accept my apologies for taking so long to get to it. We do plan on making some significant changes to the appearance of the date and time pickers to bring them in line with the latest material guidelines, accessibility guidelines, and the native Android versions. This change, like visual updates we're planning, will be backwards incompatible for tests that depend on the current behavior. Best to make all of the changes in one PR, so that downstream tests etc only have to update once. So I'm afraid I'm going to put this change off a little longer |
Adds a feature of the native Android Time Picker to our Material Time Picker. When the user selects an hour, it automatically switches to minute mode. This is a merging of two pull requests: Code changes from @sdolski #24677 Tests from @lucaslcode #29876 Thanks to both of you for your contributions!
|
Nice fix. Given that this needed to be resolved with current changes and we need tests for this, I went ahead and combined your PR with the tests from @lucaslcode #29876 and landed that in #31566. Thanks for your work on this. |
6 participants
Fixes #17276
Fixes #29600
Applied pull request tjunxiang92#1 on flutter master and fixed behaviour when selecting an hour.
@estevez-dev, @SankaCoffee could you please review?
P.S. created a new pull request because @tjunxiang92 does not have a CLA.