Implement hover support for mouse pointers.#24830
Merged
gspencergoog merged 9 commits intoflutter:masterfrom Jan 29, 2019
Merged
Implement hover support for mouse pointers.#24830gspencergoog merged 9 commits intoflutter:masterfrom
gspencergoog merged 9 commits intoflutter:masterfrom
Conversation
gspencergoog
force-pushed
the
hover
branch
4 times, most recently
from
26d60d7 to
f309365
Compare
zoechi
added
framework
Hixie
reviewed
Dec 13, 2018
Hixie
reviewed
Dec 13, 2018
Hixie
reviewed
Dec 13, 2018
Hixie
reviewed
Dec 13, 2018
Hixie
reviewed
Dec 13, 2018
Hixie
reviewed
Dec 13, 2018
Hixie
reviewed
Dec 13, 2018
Hixie
reviewed
Dec 13, 2018
Hixie
reviewed
Dec 13, 2018
Hixie
reviewed
Dec 13, 2018
Hixie
reviewed
Dec 13, 2018
Hixie
reviewed
Dec 13, 2018
Hixie
reviewed
Dec 13, 2018
Hixie
reviewed
Dec 13, 2018
Hixie
reviewed
Dec 13, 2018
Hixie
reviewed
Dec 13, 2018
Hixie
reviewed
Dec 13, 2018
Hixie
reviewed
Dec 13, 2018
Hixie
reviewed
Dec 13, 2018
Hixie
reviewed
Dec 13, 2018
Contributor
|
This seems mostly fine but one major issue I see is that it assumes that there's only one mouse. We should track each pointer separately, any number of them could be mice. |
Contributor
Author
|
Oooh, good point. OK, I've added support for multiple pointers. |
gspencergoog
force-pushed
the
hover
branch
3 times, most recently
from
65eb268 to
fa8bdc0
Compare
Hixie
reviewed
Jan 17, 2019
Hixie
reviewed
Jan 17, 2019
goderbauer
reviewed
Jan 23, 2019
Member
goderbauer
left a comment
goderbauer
left a comment
There was a problem hiding this comment.
A couple of comments from my first "let's understand what this PR does" pass. Will take another, closer look shortly.
goderbauer
reviewed
Jan 25, 2019
goderbauer
reviewed
Jan 29, 2019
kangwang1988
pushed a commit
to XianyuTech/flutter
that referenced
this pull request
Feb 12, 2019
This implements support for hovering mouse pointers, so that mice connected to Android devices, and ChromeOS devices running Android apps will work properly. It teaches flutter_test about hover events, which required changing how they are created and used. Also modifies AnnotatedRegion to allow a region that can be located someplace other than just the origin. Along with tests for all of the above. Fixes flutter#5504
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements support for hovering mouse pointers, so that mice connected to Android devices, and ChromeOS devices running Android apps will work properly.
It teaches flutter_test about hover events, which required changing how they are created and used.
Also modifies
AnnotatedRegionto allow a region that can be located someplace other than just the origin.Along with tests for all of the above.
This code needs flutter/engine#6961 in order to actually receive hover events, but doesn't require it to compile.
Fixes #5504