WIP Integration Test for Japanese Text Crash#24861
WIP Integration Test for Japanese Text Crash#24861justinmc wants to merge 1 commit intoflutter:masterfrom
Conversation
|
@HansMuller This is a work in progress but so far I have:
Is that generally the right track so far? Are my next steps to somehow expose a way to call |
justinmc
force-pushed
the
japanese-text-clear-test
branch
from
6837812 to
b6f973d
Compare
zoechi
added
a: tests
justinmc
force-pushed
the
japanese-text-clear-test
branch
from
b6f973d to
4a9324c
Compare
justinmc
force-pushed
the
japanese-text-clear-test
branch
from
4a9324c to
7dece7d
Compare
| } | ||
|
|
||
| /// TODO document and say never use this unless you really need it! | ||
| Future<void> setMarkedText(String markedTextValue, { Duration timeout }) async { |
There was a problem hiding this comment.
I added these three methods to driver. setMarkedText might not be necessary, but I was using it to try to reproduce the crash (unsuccessfully) exactly as it happens.
There was a problem hiding this comment.
After looking into this with @HansMuller, the engine side of setEditingState seems to be unable to update the engine's native text input to contain marked text.
| Future<SetMarkedTextResult> _setMarkedText(Command command) async { | ||
| final SetMarkedText setMarkedTextCommand = command; | ||
| // TODO pass finder with command rather than using hard coded key | ||
| BinaryMessages.testSend( |
There was a problem hiding this comment.
This is how I was able to send messages to the engine, bypassing mocking. The engine does receive these commands, but the textfield doesn't update in the simulator.
|
I'm unable to reproduce the crash because I can't insert marked text into a Cupertino text field. I'm closing this in favor of an issue that addresses this problem: #24955 |
3 participants
Integration test for: flutter/engine#6989