Change the tooltip background color#25844
Closed
anisalibegic wants to merge 1 commit intoflutter:masterfrom
anisalibegic:master
Closed
Change the tooltip background color#25844anisalibegic wants to merge 1 commit intoflutter:masterfrom anisalibegic:master
anisalibegic wants to merge 1 commit intoflutter:masterfrom
anisalibegic:master
Conversation
zoechi
added
framework
|
+1, but afaik the material design spec mentions only the dark color for the tooltip background. Is this change not going to break the existing functionality in some cases? Maybe an additional bool param should be added to tooltip widget constructor to assure backwards compatibility. |
9 tasks
9 tasks
|
I think this might be closed due to the merged #36856 . |
Contributor
|
Yes, there is now a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the tooltip background color same as the theme background color. Currently, it takes the default theme background color which is the dark grey. Basically, I made it so it takes the context's theme background color which can be overwritten when defining MaterialApp theme.