Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

I signed it!

CLAs look good, thanks!

Analysis is still unhappy because of whitespace at the end of a line - can you fix that up?

Can you add a test that fails without this change?

e.g. a test that shows how you're able to get rid of the unwanted scrolling behavior you mention

Ran it through the VSCode Format command so hope that solved the whitespace issue.

I'm not sure how to create a unit test to demonstrate why I'm proposing this PR but let's say we have a ListView including a Stepper:

ListView(
        children: <Widget>[
          Text('long text'),
          Stepper(
              //stuff here
              ),
          Text('more long text'),

The ListView within the Stepper will mess with the parent ListView resulting in the user being unable to scroll down the page:

With adding a physics prop to the Stepper, the developer is easily able to prevent this from happening by using another kind of ScrollPhysics such as ClampingScrollPhysis which results in this:

ListView(
        children: <Widget>[
          Text('long text'),
          Stepper(
              physics: ClampingScrollPhysics(),
              //other stuff here
              ),
          Text('more long text'),

You could achieve this using a NestedScrollView and setting up a ScrollController etc but I think this simple change results in the same result with it being far easier to implement as the developer.

We don't really have a lot of success with dartfmt on this repo, unfortunately. It does some strange things with linebreaks that don't fit with the style of the repo. VSCode actually has a setting to trim whitespace for you:

Can you revert the dartfmt for this and reapply your other changes?

As far as a test goes, you should be able to create a testWidgets that creates your problematic scenario, uses a tester.tap or tester.fling or somesuch to try to scroll it, and verify what's visible on the screen. With physics set to null, you should be able to expect that the first list item is still visible - with it set to ClampingScrollPhysics you should expect to see new items visible.

Okay got the format right (finally) and added tests. Let me know if these are acceptable and thanks for helping (you can really tell this is my first PR to a Google project).

Sorry this has taken so long to reach the finish line!

I'm going to fix up the last formatting problems and a note to the physics property doc about using ClampingScrollPhysics when the stepper is used within another scrolling container. And then, when the build is green I'll land the changes.

Thanks again for your contribution!

Can we get the Stepper's physics to also be implemented for StepperType.horizontal? I've changed it manually for now but presume the physics needs to be updated for the ListView where StepperType.horizontal?

Temp solution is to add:
physics: widget.physics,
after Expanded( child: ListView(
near line 671 in file stepper.dart