Skip to content

@author Kushal, Desc: Support added to change the icon of DropDownButton#26530

Closed
kushalmahapatro wants to merge 1 commit intoflutter:masterfrom
kushalmahapatro:master
Closed

@author Kushal, Desc: Support added to change the icon of DropDownButton#26530
kushalmahapatro wants to merge 1 commit intoflutter:masterfrom
kushalmahapatro:master

Conversation

@kushalmahapatro
Copy link

@kushalmahapatro kushalmahapatro commented Jan 14, 2019

If the user opts to change the icon of DropDownMenu, then they can just set the respective icon, if left empty the DropDownMenu will have the default icon.

@zoechi zoechi added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Jan 14, 2019
@HansMuller HansMuller changed the title @author Kushal, Desc: Support added to change the icon of DropDownMenu @author Kushal, Desc: Support added to change the icon of DropDownButton Mar 8, 2019
@HansMuller
Copy link
Contributor

HansMuller commented Mar 8, 2019

This appears to be the same changes as #23834. As with that PR:

This looks like a reasonable DropdownButton enhancement and I think making the icon configurable jibes with Material's emphasis on customization.

It would be more flexible if the icon's type was Widget and the IconTheme widget was used to configure the icon's size/color.

If icon is allowed to be null (also seems reasonable), the implementation needs to DTRT.

A test will be needed.

@HansMuller HansMuller added the waiting for customer response The Flutter team cannot make further progress on this issue until the original reporter responds label Mar 8, 2019
@shihaohong shihaohong mentioned this pull request Mar 18, 2019
Merged
10 tasks
@shihaohong
Copy link
Contributor

shihaohong commented Apr 4, 2019

Since a fix has been made in #29572, I will close this PR. Thank you for your contribution! It was very helpful with understanding what devs wanted with the DropdownButton icon.

@shihaohong shihaohong closed this Apr 4, 2019
@kushalmahapatro
Copy link
Author

kushalmahapatro commented Apr 4, 2019

Since a fix has been made in #29572, I will close this PR. Thank you for your contribution! It was very helpful with understanding what devs wanted with the DropdownButton icon.

Thank you @shihaohong .

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. waiting for customer response The Flutter team cannot make further progress on this issue until the original reporter responds

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kushalmahapatro @HansMuller @shihaohong @zoechi