[O] Removing all timeouts (mark II)#26736
Merged
Hixie merged 2 commits intoflutter:masterfrom Jan 19, 2019
Merged
Conversation
Contributor
Author
|
cc @tvolkert Sorry this is a mess to review; I couldn't create new commits for most of the changes because they ended up being done as part of merges. |
Hixie
force-pushed
the
flakes
branch
5 times, most recently
from
726008b to
057e30e
Compare
zoechi
added
a: tests
* Remove many timeouts. These are essentially self-inflicted race conditions. Instead of timeouts we're going to try a more verbose logging mechanism that points out when things are taking a long time. * Get the attach tests to pass. * Apply review comments from Todd * More review comment fixes * Put back the extended timeouts here now that I know why we have them...
jonahwilliams
pushed a commit
that referenced
this pull request
Jan 19, 2019
kangwang1988
pushed a commit
to XianyuTech/flutter
that referenced
this pull request
Feb 12, 2019
These are essentially self-inflicted race conditions. Instead of timeouts we're going to try a more verbose logging mechanism that points out when things are taking a long time.
kangwang1988
pushed a commit
to XianyuTech/flutter
that referenced
this pull request
Feb 12, 2019
8 tasks
| } | ||
| _log.trace('Waiting for service extension'); | ||
| // We will never receive the extension event if the user does not | ||
| // register it. If that happens, show a message but continue waiting. |
There was a problem hiding this comment.
This also means that if the flutter app crashed on startup we'll sit here forever.
Is there a way to handle that better?
I know that crashes are fairly rare and it may not be worth special casing them, just checking since I'm looking at one (#35890) right now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.