[WIP] Move observatory discovery into device class#27455
Closed
jonahwilliams wants to merge 4 commits intoflutter:masterfrom
Closed
[WIP] Move observatory discovery into device class#27455jonahwilliams wants to merge 4 commits intoflutter:masterfrom
jonahwilliams wants to merge 4 commits intoflutter:masterfrom
Conversation
zoechi
added
c: contributor-productivity
Contributor
|
Should we just make the Android devices use a log scanner like they do today for this? I think overall this approach makes sense though. |
Contributor
Author
|
Not sure what you mean - they do unless a port is provided? |
Contributor
|
I'm thinking in terms of getting away from using log scanners for this, although maybe that's not the best idea as I think about it some more. |
Contributor
Author
|
Oh right - long term yes we should - however fuchsia and Android/iOS will always have different implementations, and there will probably be a wide gap on the web and desktop too |
Contributor
Author
|
Closing until I have a change to work on this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep attach implementation lean, make it easier to gradually add mdns support.
TODO: verify that logging call can be safely removed for fuchsia.