Move Brightness to dart:ui in the engine (#27479).#27481
Move Brightness to dart:ui in the engine (#27479).#27481matthew-carroll merged 1 commit intoflutter:masterfrom
Conversation
e787514 to
f661d38
Compare
f661d38 to
efbb4d9
Compare
|
Now using master branch |
|
@rostopira I'm not sure what you mean by master Brightness. Can you provide sample code that shows the issue? |
|
@matthew-carroll thanks for quick response theme: new ThemeData(
brightness: Brightness.dark,Intellij IDEA says "Undefined name 'Brightness'" import 'dart:io';
import 'dart:ui';
import 'dart:isolate';
import 'dart:convert';
import 'package:flutter/services.dart';
import 'package:flutter/material.dart'; |
|
Ok, for now can you deal with that by importing Brightness
I'll look at putting up a PR tomorrow that gets Brightness back in Material or wherever it was coming from previously. |
|
You mentioned that you're importing "dart:ui", that should include Brightness. Again, I'll look in tomorrow, but I thought "dart:ui" was correctly exporting it. |
|
@matthew-carroll yeah, import 'dart:ui' show Brightness, IsolateNameServer; |
|
@rostopira so is everything working for you now, or are you still experiencing issues? |
Moves Brightness to the engine. This PR simply re-exports Brightness from system_chrome.dart to stay backwards compatible.
Engine PR is here:
flutter/engine#7678