Conversation
|
This is failing as expected. Once flutter/engine#7610 lands, we should be able to fix the failing test and make this work. Once that happens, we can just delete the existing ios_add2app repo. I was under the impression it would be important to have that separately from this because I thought we'd have to run certain commands in it that we don't actually have to to run these tests. |
|
@cbracken sorry about the size of this PR, but this is basically all of the content from github.com/flutter/ios_add2app. It figured out a way to test it without Flutter yelling at me for living in the Flutter repo. |
zoechi
added
a: tests
dnfield
force-pushed
the
add2app_test
branch
from
2e312e5 to
b6be910
Compare
|
@xster I've implemented Greg's suggestions and gotten that squared away. The Objective C app is ready for review. |
|
For the Cirrus config, at least. |
dev/integration_tests/ios_add2app/flutterapp/.android.bak/Flutter/build.gradle
Outdated
Show resolved
Hide resolved
|
|
||
| The following functionality is currently implemented: | ||
|
|
||
| 1. A regular iOS view controller, similar to the default `flutter create` template. |
There was a problem hiding this comment.
A regular fullscreen instance of a FlutterViewController? Regular iOS view controller sounds non-flutter related.
There was a problem hiding this comment.
It is. That one is just a regular iOS implementation for reference. It's also used in one of the tests for platform interaction.
| The following functionality is currently implemented: | ||
|
|
||
| 1. A regular iOS view controller, similar to the default `flutter create` template. | ||
| 1. A FlutterViewController subclass that takes over full screen. Demos showing this both from a cold/fresh engine state and a warm engine state. |
There was a problem hiding this comment.
Does the subclass do anything? Makes one ask what's the difference between this one and 1.
dev/integration_tests/ios_add2app/ios_add2app/MainViewController.h
Outdated
Show resolved
Hide resolved
|
@fkorotkov - it looks like the tests end up passing here, and on the |
|
@dnfield logs are telling that the agent just stopped sending heartbeats. Weird that it occurred twice on this PR. Trying to reproduce... |
|
I have made some changes but nothing that should cause the test process to hang. Are you able to see if any xcode related processes are still running after the success message? |
|
My task hasn't got to tests yet https://cirrus-ci.com/task/6590401151500288 |
|
@dnfield I did VCNed into the VM that were running the task and witness a VM crash 😲 Took this screenshot a few seconds before.
Not sure what's going on there. What is add2app doing differently than the other tasks? |
|
And yes. The task got to |
|
It runs xcodebuild and requires the simulator to be present to run some integration tests. My last commit (where this started failing) was just some cleanup of documentation and unrelated files... |
|
Nothing has changed to the macOS VMs lately. The only suspicious thing might be that there are many concurrent VMs are running right now since it's working hours. I will investigate over the weekend and report back here. |
|
Haven't found anything on my own. Pinged Anka folks to help with directions. |
|
Fwiw I'm seeing a lot of timeouts and slowness this afternoon. Hopefully will just pass |
|
@dnfield it seems it was a bug in the new nested virtualization feature which is enabled for mojave VMs but wasn't for High Sierra. Disabled it and now my task passed. Could you please re-run? |
|
Looks like it's working now, thanks |
6 participants
This will fix #24117
Runs some earl grey tests on an iOS simulator on Cirrus.