Lazily download artifacts (Part II): The Clone Wars#27735
Merged
jonahwilliams merged 40 commits intoflutter:masterfrom Feb 13, 2019
Merged
Lazily download artifacts (Part II): The Clone Wars#27735jonahwilliams merged 40 commits intoflutter:masterfrom
jonahwilliams merged 40 commits intoflutter:masterfrom
Conversation
added 30 commits
January 31, 2019 12:24
Fix flutter import
added 6 commits
February 7, 2019 16:09
…rms and build modes
Contributor
Author
|
Includes fix to |
gspencergoog
approved these changes
Feb 12, 2019
| await artifact.update(); | ||
| bool localClobber = clobber; | ||
| if (localClobber) { | ||
| await artifact.update(buildModes: buildModes, targetPlatforms: targetPlatforms, skipUnknown: skipUnknown, clobber: localClobber); |
Contributor
There was a problem hiding this comment.
I know we're pretty lax about line length, but these update calls are getting a little long to read.
Contributor
Author
There was a problem hiding this comment.
Since the tools don't contain widget trees, it seems like we should really consider dartfmt
Contributor
Co-Authored-By: jonahwilliams <[email protected]>
jonahwilliams
pushed a commit
that referenced
this pull request
Feb 13, 2019
This reverts commit 76061c4.
jonahwilliams
pushed a commit
that referenced
this pull request
Feb 13, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixes #6491
Only download the minimum*** set of artifacts needed for a particular host, target, and build mode.
*** I still include gradle and fonts in the minimum set.
Adds additional arguments to several Cache methods:
-skipUnknown, which allows downloading artifacts when targetPlatform and hostPlatform are unknown.
flutter precachewill still download the full set of artifacts for a given host platform.flutter precache -f/--forcewill re download all artifacts.Re-organizes engine artifacts into a class from lists of lists of strings.
Flutter commands now check the artifacts for the given or default build mode, and any connected devices. (note: android-arm-profile is downloaded unconditionally because we currently need it for a Flutter doctor check).
This is accomplished via a new method on FlutterCommand called
updateCache. This is only called ifshouldUpdateCacheis true. The default implementation is:Run, for example, looks at the current set of attached devices and ensures the binaries are downloaded for each kind.
Example doctor command: