Manual Engine roll for flutter/engine#7791 - Add trailing whitespace tracking.#27808
Merged
GaryQian merged 1 commit intoflutter:masterfrom Feb 15, 2019
Merged
Manual Engine roll for flutter/engine#7791 - Add trailing whitespace tracking.#27808GaryQian merged 1 commit intoflutter:masterfrom
GaryQian merged 1 commit intoflutter:masterfrom
Conversation
This was referenced Feb 12, 2019
GaryQian
commented
Feb 14, 2019
Contributor
Author
There was a problem hiding this comment.
There are now metrics to track trailing whitespaces (previously, they were truncated)
Member
|
I'm somewhat surprised that that was the only thing needed fixing but LGTM |
Contributor
Author
|
This only applies to centered/right aligned text with trailing whitespace. Not too many framework tests tested for this specific behavior (although it is tested well in the engine) |
Contributor
|
LGTM |
Contributor
Author
|
Will add a framework test to make sure the behavior is fully translating to the caret positioning. |
GaryQian
force-pushed
the
spacetracking
branch
from
297997a to
664b1ca
Compare
zoechi
added
a: text input
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes tests for flutter/engine#7791 and rolls the engine.
Will include actual engine roll once engine-patch lands.