Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

Googlers can find more info about SignCLA and this PR by following this link.

I signed it!

I signed it!

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

Googlers can find more info about SignCLA and this PR by following this link.

I signed it

CLAs look good, thanks!

Googlers can find more info about SignCLA and this PR by following this link.

Should I change anything to resolve this PR?

@Nizarius would you mind correcting the analysis issues?

@matthew-carroll yeah, of course.
By the way, it seems that it will be better to make not only placeholder color modifiable, but all the placeholder style at once. What do you think?
If you can make issue for that I can make pr to it. Because it's highly likely that developers want more than changing only placeholder color (for example, I want to modify font weight too and so on).

@Nizarius yes, I think we should allow an arbitrary TextStyle in a property called placeholderStyle. Let's do that here. We wouldn't want to merge in color support and then immediately replace it. Can you update this PR accordingly, and ensure that all checks pass?

Also, would you mind adding some tests for this new behavior?

@matthew-carroll I updated my PR to pass all the tests.
Frankly speaking, I'm new at Flutter and don't really understand what tests should I add for this new behavior.

Thanks @Nizarius.

@xster let's discuss on Tuesday if we should carry this PR across the finish line.

Sure.

@Nizarius, adding tests does sound a bit overwhelming initially though if you take a look at https://github.com/flutter/flutter/blob/master/packages/flutter/test/cupertino/text_field_test.dart, there are already tons of examples that you can base new tests off of. Some even creates and asserts the styles of the placeholder text. I'd create a new test based off of that one to make sure custom placeholder styles are respected.

@xster @matthew-carroll I fixed code according to your notes and also added test for placeholder's style.

@xster @matthew-carroll hi guys. Is there anything I need to do?

@Nizarius there's some trickiness with the whole TextStyle merge thing that isn't really easy to explain so we tweaked the doc in your branch a bit. Hope that's ok.

The rest of the PR looks good to us. We'll merge it in when our tree is green. Thanks for the contribution.

@xster @matthew-carroll thank you, guys. Hope Flutter will continue to evolve.

Thanks for your contribution