Remove json_schema and cli_util deps from flutter_tool#28040
Merged
dnfield merged 5 commits intoflutter:masterfrom Feb 20, 2019
Merged
Remove json_schema and cli_util deps from flutter_tool#28040dnfield merged 5 commits intoflutter:masterfrom
dnfield merged 5 commits intoflutter:masterfrom
Conversation
dnfield
added
c: contributor-productivity
dnfield
changed the title
Contributor
|
If we already have some test coverage on the validation? If not it should be straightforward to add some valid/invalid tests |
Contributor
Author
|
There are some tests that hit this but can add more. |
Contributor
|
If we cover basic validation then I am ok with it as is. If the tests use the filesystem though this might be a good chance to replace it with a faster unit test |
Contributor
Author
|
Nah these all pass in strings and test the strings. Some of them test memoryFS to make sure it works with this too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #28019
Fixes #28021
Eliminates dependencies on json_schema and dart2_constant from flutter_tool
cli_util usage was removed in #16979 but just never updated pubspec.