Log pub return code on failure on Windows#28356
Merged
cbracken merged 1 commit intoflutter:masterfrom Mar 1, 2019
Merged
Conversation
When pub fails, log the %ERRRORLEVEL% to help diagnose the root cause of the pub failure.
zoechi
added
tool
goderbauer
approved these changes
Feb 25, 2019
Member
goderbauer
left a comment
goderbauer
left a comment
There was a problem hiding this comment.
LGTM
Do we print out the same is the Bash script for Linux/Mac? Should we make the same change there?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When pub fails, log the %ERRRORLEVEL% to help diagnose the root cause of
the pub failure.