Add hero groups to support hero animations with nested navigators#28420
Closed
spkersten wants to merge 1 commit intoflutter:masterfrom
Closed
Add hero groups to support hero animations with nested navigators#28420spkersten wants to merge 1 commit intoflutter:masterfrom
spkersten wants to merge 1 commit intoflutter:masterfrom
Conversation
spkersten
force-pushed
the
hero_groups
branch
from
513ca2b to
92b0140
Compare
spkersten
force-pushed
the
hero_groups
branch
from
92b0140 to
d814dcb
Compare
zoechi
added
framework
Contributor
|
I think a simpler solution would be to avoid walking into nested Navigators. |
10 tasks
Member
|
Alternative approach: #29069 |
Contributor
Author
|
Closing, since @goderbauer's alternative looks better. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an implementation for the solution (1b) mentioned in #28042.