TwoLevelList fails to restore sublist expanded state#2846
Merged
HansMuller merged 1 commit intoflutter:masterfrom Mar 23, 2016
Merged
TwoLevelList fails to restore sublist expanded state#2846HansMuller merged 1 commit intoflutter:masterfrom
HansMuller merged 1 commit intoflutter:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
You probably want to increment itemIndex every trip through the loop, regardless of whether the item.key is null.
I wonder if we want to break this out into a helper function (maybe a static on KeyedSubtree) now that we've got this pattern in two places. KeyedSubtree.ensureKeysForList(...) ?
Contributor
Author
There was a problem hiding this comment.
Sure, will do that.
Contributor
|
LGTM |
HansMuller
force-pushed
the
two_level_list
branch
from
1bf230e to
486edaa
Compare
HansMuller
force-pushed
the
two_level_list
branch
from
486edaa to
67a18fa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each TwoLevelList item needs a unique key to ensure that it ends up with its own expanded state.
Added a TwoLevelList scrollableKey parameter so that its Block can be used to drive the AppBar.
Fixes #2845