Skip to content

Be more strict about finding version number attached to a revision when packaging.#28527

Merged
gspencergoog merged 1 commit intoflutter:masterfrom
gspencergoog:package_hotfix
Mar 1, 2019
Merged

Be more strict about finding version number attached to a revision when packaging.#28527
gspencergoog merged 1 commit intoflutter:masterfrom
gspencergoog:package_hotfix

Conversation

@gspencergoog
Copy link
Contributor

@gspencergoog gspencergoog commented Feb 26, 2019

Description

When we package Flutter, we used to find the "current" tag (which is the version number) by starting at the revision we are building on and looking backwards in time to find the most recent tag. This causes problems on release builds when we failed to tag properly.

This PR makes the packaging script be more strict by requiring the given revision to itself have a tag, but only when we're publishing the result. When we're not publishing the result, it's more lenient, since otherwise we couldn't test packaging on non-release commits.

I also renamed ProcessRunnerException to PreparePackageException, since we were using that exception more generally than just for processes.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • My PR includes tests for all changed/updated/fixed behaviors (See [Test Coverage]).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • No, this is not a breaking change.

@gspencergoog gspencergoog changed the title Be more strict about finding version number attached to a revision. Be more strict about finding version number attached to a revision when packaging. Feb 26, 2019
Copy link
Contributor

@kf6gpe kf6gpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like someone else to review, but this looks good to me.

@zoechi zoechi added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Feb 27, 2019
@Hixie
Copy link
Contributor

Hixie commented Feb 28, 2019

LGTM

@gspencergoog gspencergoog merged commit 7ab3bc7 into flutter:master Mar 1, 2019
@gspencergoog gspencergoog deleted the package_hotfix branch May 15, 2019 16:30
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants