Reland "Shader warm up (#27660)" by liyuqian · Pull Request #28537 · flutter/flutter

liyuqian · 2019-02-26T23:57:19Z

This reverts commit adc8e15.

This should be safe to land once #28530 gets merged

This reverts commit adc8e15.

jonahwilliams · 2019-02-26T23:58:56Z

packages/flutter/lib/src/painting/shader_warm_up.dart

@@ -0,0 +1,148 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.


Should these be 2019?

jonahwilliams · 2019-02-27T01:39:23Z

examples/layers/test/smoketests/raw/shader_warm_up_test.dart

@@ -0,0 +1,13 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.


Suggested change

// Copyright 2017 The Chromium Authors. All rights reserved.

// Copyright 2019 The Chromium Authors. All rights reserved.

jonahwilliams · 2019-02-27T01:39:29Z

examples/layers/raw/shader_warm_up.dart

@@ -0,0 +1,33 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.


Suggested change

// Copyright 2015 The Chromium Authors. All rights reserved.

// Copyright 2019 The Chromium Authors. All rights reserved.

jonahwilliams · 2019-02-27T01:39:38Z

dev/devicelab/bin/tasks/cubic_bezier_perf__timeline_summary.dart

@@ -0,0 +1,14 @@
+// Copyright 2018 The Chromium Authors. All rights reserved.


Suggested change

// Copyright 2018 The Chromium Authors. All rights reserved.

// Copyright 2019 The Chromium Authors. All rights reserved.

jonahwilliams · 2019-02-27T01:39:45Z

dev/benchmarks/macrobenchmarks/test_driver/util.dart

@@ -0,0 +1,44 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.


Suggested change

// Copyright 2015 The Chromium Authors. All rights reserved.

// Copyright 2019 The Chromium Authors. All rights reserved.

jonahwilliams · 2019-02-27T01:39:53Z

dev/benchmarks/macrobenchmarks/test_driver/cubic_bezier_perf_test.dart

@@ -0,0 +1,11 @@
+// Copyright 2018 The Chromium Authors. All rights reserved.


Suggested change

// Copyright 2018 The Chromium Authors. All rights reserved.

// Copyright 2019 The Chromium Authors. All rights reserved.

jonahwilliams · 2019-02-27T01:39:59Z

dev/benchmarks/macrobenchmarks/test_driver/cubic_bezier_perf.dart

@@ -0,0 +1,40 @@
+// Copyright 2018 The Chromium Authors. All rights reserved.


Suggested change

// Copyright 2018 The Chromium Authors. All rights reserved.

// Copyright 2019 The Chromium Authors. All rights reserved.

jonahwilliams · 2019-02-27T01:40:13Z

dev/benchmarks/macrobenchmarks/lib/src/cubic_bezier.dart

@@ -0,0 +1,380 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.


Suggested change

// Copyright 2015 The Chromium Authors. All rights reserved.

// Copyright 2019 The Chromium Authors. All rights reserved.

liyuqian

Thanks again! Sorry that I forget to check other files...

liyuqian · 2019-02-27T05:11:37Z

dev/benchmarks/macrobenchmarks/lib/src/cubic_bezier.dart

@@ -0,0 +1,380 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.


liyuqian · 2019-02-27T05:12:15Z

dev/benchmarks/macrobenchmarks/test_driver/cubic_bezier_perf.dart

@@ -0,0 +1,40 @@
+// Copyright 2018 The Chromium Authors. All rights reserved.


liyuqian · 2019-02-27T05:12:23Z

dev/benchmarks/macrobenchmarks/test_driver/cubic_bezier_perf_test.dart

@@ -0,0 +1,11 @@
+// Copyright 2018 The Chromium Authors. All rights reserved.


liyuqian · 2019-02-27T05:12:41Z

dev/benchmarks/macrobenchmarks/test_driver/util.dart

@@ -0,0 +1,44 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.


liyuqian · 2019-02-27T05:12:56Z

dev/devicelab/bin/tasks/cubic_bezier_perf__timeline_summary.dart

@@ -0,0 +1,14 @@
+// Copyright 2018 The Chromium Authors. All rights reserved.


liyuqian · 2019-02-27T05:13:11Z

examples/layers/raw/shader_warm_up.dart

@@ -0,0 +1,33 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.


liyuqian · 2019-02-27T05:13:26Z

examples/layers/test/smoketests/raw/shader_warm_up_test.dart

@@ -0,0 +1,13 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.


jonahwilliams

LGTM

Reland "Shader warm up (flutter#27660)"

260a519

This reverts commit adc8e15.

googlebot added the cla: yes label Feb 26, 2019

liyuqian requested review from jonahwilliams and xster February 26, 2019 23:57

jonahwilliams reviewed Feb 26, 2019

View reviewed changes

Fix year

8e53aa2

jonahwilliams reviewed Feb 27, 2019

View reviewed changes

Fix more years

a93ff2a

liyuqian commented Feb 27, 2019

View reviewed changes

jonahwilliams approved these changes Feb 27, 2019

View reviewed changes

zoechi added framework flutter/packages/flutter repository. See also f: labels. c: performance Relates to speed or footprint issues (see "perf:" labels) labels Feb 27, 2019

liyuqian merged commit 19a6a6f into flutter:master Feb 27, 2019

HansMuller mentioned this pull request Apr 2, 2019

flutter_gallery__start_up timeToFirstFrameMicros regressed #30401

Closed

github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2021

		@@ -0,0 +1,148 @@
		// Copyright 2015 The Chromium Authors. All rights reserved.

		@@ -0,0 +1,13 @@
		// Copyright 2017 The Chromium Authors. All rights reserved.

	// Copyright 2017 The Chromium Authors. All rights reserved.
	// Copyright 2019 The Chromium Authors. All rights reserved.

		@@ -0,0 +1,33 @@
		// Copyright 2015 The Chromium Authors. All rights reserved.

		@@ -0,0 +1,14 @@
		// Copyright 2018 The Chromium Authors. All rights reserved.

		@@ -0,0 +1,44 @@
		// Copyright 2015 The Chromium Authors. All rights reserved.

		@@ -0,0 +1,11 @@
		// Copyright 2018 The Chromium Authors. All rights reserved.

		@@ -0,0 +1,40 @@
		// Copyright 2018 The Chromium Authors. All rights reserved.

		@@ -0,0 +1,380 @@
		// Copyright 2015 The Chromium Authors. All rights reserved.

Conversation

liyuqian commented Feb 26, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

liyuqian left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jonahwilliams left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants