Fix ink highlight effect of RawChip#28653
Merged
HansMuller merged 2 commits intoflutter:masterfrom Mar 1, 2019
Merged
Conversation
ocavue
force-pushed
the
fix_chip_ink_highlight_
branch
from
63e67d1 to
515377e
Compare
Use InkWell instead of InkResponse to provide highlight. Fixed: flutter#28646
ocavue
force-pushed
the
fix_chip_ink_highlight_
branch
from
515377e to
88246f7
Compare
ocavue
changed the title
HansMuller
approved these changes
Mar 1, 2019
Contributor
HansMuller
left a comment
HansMuller
left a comment
There was a problem hiding this comment.
LGTM, thanks for the contribution!
I will land this as soon as its possible to land this.
HansMuller
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Make the ink highlight effect of
RawChipfollow its shape.Related Issues
Fixed: #28646
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?