Skip to content

FAB Snippet for API Docs#28752

Merged
Piinks merged 3 commits intoflutter:masterfrom
Piinks:fabSample
Mar 4, 2019
Merged

FAB Snippet for API Docs#28752
Piinks merged 3 commits intoflutter:masterfrom
Piinks:fabSample

Conversation

@Piinks
Copy link
Contributor

@Piinks Piinks commented Mar 1, 2019

Description

This PR adds 2 code snippets for the FloatingActionButton class in the API docs. The first is a simple case, the second illustrates the use of the extended FAB constructor.

For your consideration dear reviewer...
I used the stateless widget template, and left the onPressed properties empty in these samples to focus on a simple example of constructing the FAB widget.
If changing this template to a stateful widget and implementing the popular counter example (or something similar) would be better to further exemplify this widget, share your thoughts below and I can modify it!

Related Issues

Ref: #21136

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes tests for all changed/updated/fixed behaviors (See Test Coverage).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

@Piinks Piinks added d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos labels Mar 1, 2019
@Piinks Piinks marked this pull request as ready for review March 1, 2019 23:55
@goderbauer goderbauer added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Mar 4, 2019
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

(modulo whitespace nits)

gspencergoog and others added 2 commits March 4, 2019 10:36
@Piinks
Copy link
Contributor Author

Piinks commented Mar 4, 2019

Interface isn't updating analyze pre-submit check result. All green on cirrus, checked by @dnfield.

@Piinks Piinks merged commit 013fd21 into flutter:master Mar 4, 2019
@Piinks Piinks deleted the fabSample branch March 20, 2019 19:58
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants