Added opacity to cupertino switch when disabled#29451
Conversation
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
|
Seems like there are 2 users involved in this. Make sure your GitHub account's email and your .gitconfig's [user] is the same user. |
|
@xster Am I right in thinking I can view that by running this: |
|
The author field on the commit seems to end with "MacBook-Pro.local". I guess it made that up based on your username/machine name because you hadn't configured any. The command you gave above will fix this for future commits, but you'll need to fix this commit, which I think you can do with: Then you'd have to force push (be careful doing this, if done in the wrong place or from the wrong branch, you could lose work). |
0873e96 to
9c2b9ad
Compare
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
|
These tests were passing before I changed the author on the commit, is it because the build went down? If so how do I get the tests to run again? |
|
The failed tests looked like infrastructure issues (io errors/failed to launch instances) so I've restarted them. |
|
@DanTup Thanks, for future reference how did you do that? |
|
@Robiquet it requires committer access to this repo (there is a re-run button on the Cirrus pages). Another way to do it would be to just push an empty commit commit (for ex. |
xster
left a comment
There was a problem hiding this comment.
Thanks for adding the test. This looks good to me. I just left some minor comments.
|
I think you resolved the comments but forgot to push your newest commits :) |
xster
left a comment
There was a problem hiding this comment.
Looks good. Just a few more comments.
Tests for 'Switch turns translucent after becoming disabled' and 'Switch turns opaque after becoming enabled.' Also some small modifications to docs
Description
Wrapped the widget in an opacity, if onChange is null the opacity is 0.4 otherwise it is 1.0
Related Issues
#29164
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?