Let CupertinoTextField's clear button also call onChanged#29474
Merged
xster merged 7 commits intoflutter:masterfrom Mar 26, 2019
Merged
Let CupertinoTextField's clear button also call onChanged#29474xster merged 7 commits intoflutter:masterfrom
xster merged 7 commits intoflutter:masterfrom
Conversation
goderbauer
added
framework
xster
changed the title
xster
reviewed
Mar 20, 2019
Member
xster
left a comment
xster
left a comment
There was a problem hiding this comment.
Thanks for your contribution. The approach is fine. Please add some tests in cupertino/text_field_test.dart.
Contributor
Author
|
All test and checks have passed, thanks for you patient. @xster |
xster
reviewed
Mar 22, 2019
Contributor
Author
|
Benefiting so much of you conversation! @xster |
Member
|
LGTM, thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
CupertinoTextField does not call onChanged when its clear button is tapped.
Related Issues
#29345.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?