Skip to content

DropdownButton Icon customizability#29572

Merged
shihaohong merged 11 commits intoflutter:masterfrom
shihaohong:dropdownbutton-icon
Mar 20, 2019
Merged

DropdownButton Icon customizability#29572
shihaohong merged 11 commits intoflutter:masterfrom
shihaohong:dropdownbutton-icon

Conversation

@shihaohong
Copy link
Contributor

@shihaohong shihaohong commented Mar 18, 2019

Description

This change to the DropdownButton widget allows users to define custom widgets as the icon.

Related Issues

Fixes #25151
Fixes #20686

A huge thank you to the following contributors for inspiration:
@mfiels : #23834
@kushalmahapatro: #26530
@taishi-h: #25198
@MatthewJones517: #28670

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes tests for all changed/updated/fixed behaviors (See Test Coverage).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

@goderbauer goderbauer added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Mar 18, 2019
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done! Just some minor comments

Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DropDownButton is not customizable Improvements: Custom DropdownButton Icon

4 participants