DropdownButton Icon customizability#29572
Merged
shihaohong merged 11 commits intoflutter:masterfrom Mar 20, 2019
shihaohong:dropdownbutton-icon
Merged
DropdownButton Icon customizability#29572shihaohong merged 11 commits intoflutter:masterfrom shihaohong:dropdownbutton-icon
shihaohong merged 11 commits intoflutter:masterfrom
shihaohong:dropdownbutton-icon
Conversation
HansMuller
reviewed
Mar 19, 2019
Contributor
HansMuller
left a comment
There was a problem hiding this comment.
Nicely done! Just some minor comments
10 tasks
This was referenced Apr 4, 2019
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change to the DropdownButton widget allows users to define custom widgets as the icon.
Related Issues
Fixes #25151
Fixes #20686
A huge thank you to the following contributors for inspiration:
@mfiels : #23834
@kushalmahapatro: #26530
@taishi-h: #25198
@MatthewJones517: #28670
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?