Skip to content

Table widget#2961

Merged
Hixie merged 1 commit intoflutter:masterfrom
Hixie:table
Mar 29, 2016
Merged

Table widget#2961
Hixie merged 1 commit intoflutter:masterfrom
Hixie:table

Conversation

@Hixie
Copy link
Contributor

@Hixie Hixie commented Mar 28, 2016

  • Add x and y to the parent data, in case it's useful. In point of fact,
    I ended up not needing it.
  • Make columnWidths settable rather than having a setter so that the
    code in the widgets layer is more idiomatic.
  • Teach setFlatChildren about avoiding unnecessary drop/adopt loops.
  • Assert that the child list length is correct more aggressively so that
    we catch the dumb bug I had more quickly next time.
  • Improve the toString() to handle empty tables better.
  • Resort the imports in framework.dart.
  • Introduce a LocalKey for cases where you don't want to allow use of
    GlobalKey.
  • Make inflateWidget and deactivateChild public for subclass use.
  • Table widget.
  • Cell widget.
  • TableRow fake widget.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_TableElement ?

Hixie added a commit to Hixie/mahogony-staircase that referenced this pull request Mar 29, 2016
Also, analyze everything.

This will break the build until flutter/flutter#2961 lands.
- Add x and y to the parent data, in case it's useful. In point of fact,
  I ended up not needing it.

- Make columnWidths settable rather than having a setter so that the
  code in the widgets layer is more idiomatic.

- Teach setFlatChildren about avoiding unnecessary drop/adopt loops.

- Assert that the child list length is correct more aggressively so that
  we catch the dumb bug I had more quickly next time.

- Improve the toString() to handle empty tables better.

- Resort the imports in framework.dart.

- Introduce a LocalKey for cases where you don't want to allow use of
  GlobalKey.

- Make inflateWidget and deactivateChild public for subclass use.

- Table widget.

- Cell widget.

- TableRow fake widget.
@Hixie
Copy link
Contributor Author

Hixie commented Mar 29, 2016

WRITE TESTS
FIND BUGS
PTAL

@abarth
Copy link
Contributor

abarth commented Mar 29, 2016

LGTM

@Hixie Hixie merged commit f4603f7 into flutter:master Mar 29, 2016
@Hixie Hixie deleted the table branch March 29, 2016 20:20
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants